-
Notifications
You must be signed in to change notification settings - Fork 20
feat(component): add anchor navigation functionality to <post-tab>
component
#6350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alionazherdetska
wants to merge
66
commits into
main
Choose a base branch
from
feat/tabs-anchor-navigation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π¦ Changeset detectedLatest commit: 4fd4a3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Ticket: #5940
Breaking Changes
post-tab-header
component topost-tab-item
panel
βname
inpost-tab-item
name
βfor
inpost-tab-panel
activePanel
βactiveTab
inpost-tabs
panels
slotNew Features
<nav>
element with proper ARIA attributesTesting
Documentation
Animation:
Note:
The controls table still shows both CSS Shadow Parts for both variants because Storybook automatically extracts these from the component's JSDoc
part
annotations at build time, preventing any dynamic filtering based on the selected variant control.Unlike slots, which are manually defined in the stories configuration and support conditional visibility using the
if
property, CSS Shadow Parts are auto-generated from the component source code.π Preview Link
Tabs component
π Checklist